backport: Merge bitcoin#23712 , 23346 #6308
Draft
+25
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vijaydasmp
changed the title
vijaydasmp
force-pushed
the
bp23_2024_10_05
branch
from
3f4562e to
0902963
Compare
vijaydasmp
changed the title
|
This pull request has conflicts, please rebase. |
|
This pull request has conflicts, please rebase. |
vijaydasmp
force-pushed
the
bp23_2024_10_05
branch
from
45f2d7c to
8a58b5e
Compare
vijaydasmp
changed the title
vijaydasmp
force-pushed
the
bp23_2024_10_05
branch
3 times, most recently
from
34e0c08 to
a1d6b20
Compare
vijaydasmp
changed the title
vijaydasmp
force-pushed
the
bp23_2024_10_05
branch
from
a1d6b20 to
8b6e2d0
Compare
vijaydasmp
changed the title
vijaydasmp
force-pushed
the
bp23_2024_10_05
branch
7 times, most recently
from
d54db04 to
0644cde
Compare
|
This pull request has conflicts, please rebase. |
added 2 commits
January 15, 2025 17:22
…wallet type availability b57bf25 test: interface_bitcoin_cli.py: check specified wallet type availability (Sebastian Falbesoner) Pull request description: Currently the test `interface_bitcoin_cli.py` performs the wallet-relevant parts if _any_ wallet type support is compiled in, independently of whether the test is run with legacy or descriptor wallet specified. This leads to a failure if the test is started with the `--legacy-wallet` parameter, but bitcoind is compiled without BDB support, see e.g bitcoin#23686 (comment) Fix this by checking if the specified wallet type (BDB for legacy wallet, SQLite for descriptor wallet) is available. Should further pave the way for bitcoin#23682. ACKs for top commit: achow101: ACK b57bf25 Tree-SHA512: ddb5a94ba61133eff8de79d4946b3b9d476232b26e83bf768894cac4691e72602f88b6c02c72b992e12c2feb9bff1f0a2e0a265948a00954311104add1347184
…et tool 3431839 util, refactor: Improve headers for bitcoin-wallet tool (Hennadii Stepanov) Pull request description: This PR: - removes unneeded `#include <wallet/wallet.h>` from `<wallet/wallettool.h>` - introduces class forward declaration in `<wallet/wallettool.h>` - added `#include <config/bitcoin-config.h>` to `wallet/wallettool.cpp` where the `USE_BDB` macro is used Top commit has no ACKs. Tree-SHA512: a0de560d821f8b570ae806a1165b9b382c9e0b339687d932052fa4c38ab2ba493e7e050f19adc02ad7db40c42cf88ac1d37209f9071494a0ab268ed33ff22b9f
vijaydasmp
force-pushed
the
bp23_2024_10_05
branch
from
0644cde to
e1512af
Compare
vijaydasmp
changed the title
vijaydasmp
force-pushed
the
bp23_2024_10_05
branch
from
e1512af to
321a21a
Compare
vijaydasmp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bitcoin backports